Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a11y status messages PL-17 #1206

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fixing a11y status messages PL-17 #1206

merged 3 commits into from
Nov 28, 2024

Conversation

mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Nov 20, 2024 •
edited
Loading

  • settingsDropdown should announce clearing selections
  • serviceTree, checkbox should announce "mixed" state, HDS Checkboxes do this internally
  • Clicking on additional entrances link should focus on tab

@mikkojamG mikkojamG force-pushed the fix/PL-17-a11y-status-messages branch from fbda883 to 3e5ce54 Compare November 22, 2024 08:29
@mikkojamG mikkojamG changed the title [DRAFT] PL-17 fixing a11y status messages PL-17 fixing a11y status messages Nov 22, 2024
@mikkojamG mikkojamG marked this pull request as ready for review November 22, 2024 08:51
@mikkojamG mikkojamG requested a review from a team November 22, 2024 08:51
@mikkojamG mikkojamG changed the title PL-17 fixing a11y status messages Fixing a11y status messages PL-17 Nov 22, 2024
@mikkojamG mikkojamG force-pushed the fix/PL-17-a11y-status-messages branch from 3e5ce54 to 68c5607 Compare November 28, 2024 10:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

japauliina
japauliina approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@japauliina japauliina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see the stylistic changes in separate commits but otherwise looks good.

@japauliina japauliina merged commit dfbe5a8 into develop Nov 28, 2024
3 checks passed
@japauliina japauliina deleted the fix/PL-17-a11y-status-messages branch November 28, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japauliina japauliina japauliina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkojamG @japauliina