Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user position constantly #713

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mikkoisa
Copy link
Contributor

No description provided.

Copy link
Contributor

@Dremars Dremars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine but I'm concerned about the usability and how understandable search distances are. I think we should have location marker separated from user marker. (See HSL route map) Now it's slightly confusing as to what these distances are in relation of since the location marker is moving. It makes sense when using address search to move location marker to specific position but when location marker is updated distances don't mean anything.

Should talk about this with designer.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikkoisa mikkoisa closed this Mar 28, 2022
@mikkoisa mikkoisa reopened this May 31, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mikkoisa mikkoisa requested a review from Dremars June 6, 2022 06:05
@vitalis0itu vitalis0itu force-pushed the develop branch 3 times, most recently from 515c4a7 to 6be87fa Compare January 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants