This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Docker image creation #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Travis integration is needed. Though I only added Travis in this branch https://github.com/City-of-Helsinki/servicemap/tree/feature/add-travis which is not merged yet (and isn't perhaps greatest implementation). Otherwise looks good. Though I can't compute what work-in-π means.. 🤔 |
|
Squashed into a single commit |
* move everything wrt. configuration inside one method * move everything wrt. server init inside another method * separate client side and server side config in the config object * use the separation to remove server stuff from client side * install bower modules through `prepare` hook * add empty configs for "dev" and "production" to signify validity
vikoivun
force-pushed
the
feature/docker
branch
2 times, most recently
from
a18cfa5 to
5f44922
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.