Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CI configuration #192

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

japauliina
Copy link
Collaborator

@japauliina japauliina commented Oct 20, 2023

To ensure that the tests run when opening a new PR, fix a small typo in the CI configuration.

Also, as agreed within the project, skip SonarCloud scan in PRs.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #192 (efcb4c7) into develop (625cd62) will increase coverage by 0.70%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
+ Coverage    65.90%   66.61%   +0.70%     
===========================================
  Files          214      214              
  Lines         6453     6520      +67     
  Branches       911      913       +2     
===========================================
+ Hits          4253     4343      +90     
+ Misses        2028     2006      -22     
+ Partials       172      171       -1     
Files Coverage Δ
services/api.py 57.01% <100.00%> (+1.62%) ⬆️
services/tests/test_unit_view_set_api.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@japauliina japauliina requested a review from mhieta October 20, 2023 06:32
@japauliina
Copy link
Collaborator Author

japauliina commented Oct 23, 2023

@mhieta SonarCloud is failing with "Set the SONAR_TOKEN env variable." Do you know if it is missing from project settings or is this an another kind of issue?

@japauliina japauliina changed the title Fix typo in CI configuration Draft: Fix typo in CI configuration Oct 23, 2023
@japauliina japauliina changed the title Draft: Fix typo in CI configuration Fix typo in CI configuration Oct 23, 2023
Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@japauliina japauliina merged commit 340b669 into City-of-Helsinki:develop Oct 23, 2023
@japauliina japauliina deleted the fix/typo-in-ci branch October 23, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants