Upgrade requirements #193
Merged
Upgrade requirements #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in `services_qs` ordering in search api and add tests for it.
mhieta
approved these changes
Oct 23, 2023
mhieta
requested changes
Oct 23, 2023
|
@mhieta I think the issue is that Dockerized environment has Python version 3.8 and CI configuration version 3.10. |
Change CI configuration Python version to match the Dockerized environment Python version.
This change was prompted by Flake8 check.
This was referenced Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade project requirements and fix a bug that occurred in tests after the upgrade.
Context
Refs
How Has This Been Tested?
Some manual testing locally and a new test for the found bug.