Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import 3D geodata to units #195

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

japauliina
Copy link
Collaborator

Description

Import 3D geometries from Lipas to Unit model and display them in unit endpoint only if geometry_3d parameter is given.

Context

Refs

How Has This Been Tested?

Unit tests for the new features and some manual testing, like importing the lipas data and checking that the data is correct in the unit endpoint.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #195 (10001d5) into develop (aede5d5) will increase coverage by 1.26%.
The diff coverage is 96.34%.

@@             Coverage Diff             @@
##           develop     #195      +/-   ##
===========================================
+ Coverage    67.26%   68.53%   +1.26%     
===========================================
  Files          215      218       +3     
  Lines         6471     6551      +80     
  Branches       879      884       +5     
===========================================
+ Hits          4353     4490     +137     
+ Misses        1948     1886      -62     
- Partials       170      175       +5     
Files Coverage Δ
services/api.py 57.20% <100.00%> (+0.29%) ⬆️
services/migrations/0115_unit_geometry_3d.py 100.00% <100.00%> (ø)
services/models/unit.py 79.02% <100.00%> (+0.14%) ⬆️
services/tests/test_lipas_import_3d.py 100.00% <100.00%> (ø)
services/tests/test_unit_view_set_api.py 100.00% <100.00%> (ø)
services/management/commands/lipas_import.py 66.66% <85.71%> (+66.66%) ⬆️
services/management/commands/lipas_import_3d.py 88.23% <88.23%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@japauliina japauliina requested a review from mhieta October 31, 2023 10:16
Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 💯

@japauliina japauliina merged commit a5bdf3b into City-of-Helsinki:develop Nov 1, 2023
1 check passed
@japauliina japauliina deleted the feature/geometry_3d branch November 1, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants