Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API documentation #217

Merged

Conversation

japauliina
Copy link
Collaborator

@japauliina japauliina commented Dec 19, 2023

Description

Add missing parameters to API documentation.

Manual Testing Instructions for Reviewers

Check e.g http://localhost:8000/schema/swagger-ui/

@japauliina japauliina force-pushed the improvement/update-docs branch from 472d771 to 99cc34e Compare December 19, 2023 12:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18022a0) 69.82% compared to head (99cc34e) 69.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
+ Coverage    69.82%   69.86%   +0.03%     
===========================================
  Files          223      223              
  Lines         6781     6789       +8     
  Branches      1101     1104       +3     
===========================================
+ Hits          4735     4743       +8     
  Misses        1868     1868              
  Partials       178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@japauliina japauliina changed the title WIP: Add documentation Add missing API documentation Dec 22, 2023
@japauliina japauliina marked this pull request as ready for review December 22, 2023 12:11
@japauliina japauliina requested a review from mhieta December 22, 2023 12:17
Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@japauliina japauliina merged commit e620c33 into City-of-Helsinki:develop Jan 11, 2024
4 checks passed
@japauliina japauliina deleted the improvement/update-docs branch January 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants