Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Vantaa parking payzones from ArcGIS Server #233

Conversation

japauliina
Copy link
Collaborator

@japauliina japauliina commented Feb 1, 2024

Description

Import, update and delete Vantaa's parking payzones in similar way as parking areas.

Context

Refs

How Has This Been Tested?

Imported the data locally and added an unit test with a mock data.

@japauliina japauliina force-pushed the feature/import-vantaa-parking-payzones branch from c347116 to 3f4e2ee Compare February 1, 2024 11:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (88ed8c5) 71.47% compared to head (01b2e32) 71.72%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...agement/commands/update_vantaa_parking_payzones.py 87.50% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
+ Coverage    71.47%   71.72%   +0.24%     
===========================================
  Files          228      230       +2     
  Lines         7088     7189     +101     
  Branches      1128     1101      -27     
===========================================
+ Hits          5066     5156      +90     
- Misses        1847     1857      +10     
- Partials       175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@japauliina japauliina marked this pull request as draft February 1, 2024 11:14
@japauliina japauliina force-pushed the feature/import-vantaa-parking-payzones branch 2 times, most recently from 2670be9 to 3a510ac Compare February 1, 2024 12:45
@japauliina japauliina marked this pull request as ready for review February 1, 2024 12:53
@japauliina japauliina requested a review from mhieta February 1, 2024 12:53
@japauliina japauliina marked this pull request as draft February 6, 2024 08:48
@japauliina japauliina marked this pull request as ready for review February 6, 2024 10:04
@japauliina japauliina force-pushed the feature/import-vantaa-parking-payzones branch from 3a510ac to e9291b3 Compare February 6, 2024 10:41
Import, update and delete Vantaa's parking payzones in similar way as
parking areas.
@japauliina japauliina force-pushed the feature/import-vantaa-parking-payzones branch from e9291b3 to 6c27c9c Compare February 7, 2024 06:35
Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple of notes.

Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhieta mhieta merged commit ae31fc8 into City-of-Helsinki:develop Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants