Rework search query building #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the error more informative. Didn't include any traceback.
Use the APIClient data parameter for setting query params instead of manually setting them in the URL. The data parameter automatically encodes the query params while the manual option does not. E.g. & needs to be encoded, otherwise it's interpreted as a part of the query string (?q=halli&museo results in two query params, q and museo) Also parametrize the test so one failing test won't block the other tests. Makes it more compact, too.
- accept commas - don't crash on ampersands - split operands correctly - strip operands with repeating single-quotes - retain or operators
voneiden
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several issues with the search:
dataparameter for query parameters instead of manually inserting them in the URLdataparameter, the query parameters get correctly encoded, e.g.&becomes%26foo&barneeds to befoo%26bar, otherwise it's interpreted as a separator''''' | foobecomesfoo:*)Known issues:
Single-quotes might mess with the query, but the original implementation didn't really deal with them either, so left it as it is (aside from fixing some of the errors caused by
's.)Context
Using
&in a search query causes an error. Found other issues while investigating this, e.g. some part of the code was unreachable,foo|barwas interpreted as is (becomingfoo|bar:*in the SQL), butfoo| bar,foo |barandfoo | barwould turn into ANDs (becomingfoo & bar:*)PL-38
How Has This Been Tested?
Unit tests.
Manual Testing Instructions for Reviewers
You can test it through the API with different queries, e.g. http://localhost:8000/v2/search/?q=a%26b