Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSV exports #1448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor CSV exports #1448

wants to merge 1 commit into from

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 22, 2024 •
edited
Loading

🛠️ Changelog

  • Add PYTHONIOENCODING to the docker container
  • Rewrite ReservationUnit export to use BaseCSVExporter (should fix broken export in prod)
  • Enhance formatting on ReservationUnit export
  • Consolidate export logic from exporters to BaseCSVExporter
  • Move exporters to services

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu
Refactor CSV exports
9fd6daf 
- Rewrite ReservationUnit export to use BaseCSVExporter
- Consolidate export logic from exporters to BaseCSVExporter
- Move exporters to services
@matti-lamppu matti-lamppu self-assigned this Nov 22, 2024
@github-actions github-actions bot added the fix Fixes a bug label Nov 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matti-lamppu matti-lamppu marked this pull request as ready for review November 22, 2024 16:29
ranta
ranta approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ranta ranta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have split this in multiple commits (e.g. docker stuff in one, moving the files in one, then modifying them to let git know it's the same file and show less changes in this PR) 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama Awaiting requested review from vergama

Assignees

@matti-lamppu matti-lamppu

Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matti-lamppu @ranta