Fix reservation unit state #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
from
00885de
to
1f925f1
Compare
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
2 times, most recently
from
5a1e9c2
to
8b60498
Compare
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
4 times, most recently
from
6312e44
to
1d6c5ac
Compare
joonatank
reviewed
Mar 25, 2024
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
from
337da60
to
529d093
Compare
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
3 times, most recently
from
c1d874f
to
b03313d
Compare
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
from
b03313d
to
87cca1f
Compare
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
from
07d74be
to
f6273e4
Compare
- "asInt" is misleading, since it's desired effect is to ensure that the return value consists of numbers (like "0" instead of "free") - but we are still returning a string and not anything typed number (like "asInt" would suggest). - "reservationUnitIsReservable" differentiates it from the reservability for a single slot (= a result of an isSlotReservable() operation, whereas this is isReservationUnitReservable).
- remove as much logic as possible from quick reservation and calendar controls - move over some utility functions from quick reservation to utils.ts, even if they aren't in use elsewhere
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
2 times, most recently
from
fe24721
to
cf4ee48
Compare
joonatank
reviewed
Apr 12, 2024
apps/ui/components/reservation-unit/ReservationInfoContainer.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+507
to
+511
| const initialFieldValues = { | ||
| date: | ||
| searchDate && searchUIDate && isValidDate(searchUIDate) | ||
| ? searchDate | ||
| : toUIDate(new Date(todaysTimeSpans[0]?.startDatetime ?? "")), |
There was a problem hiding this comment.
Date format? here it's in UI.
There was a problem hiding this comment.
It's supposed to be in UI format in the form/state.. searchDate is in UI format too..
joonatank
reviewed
Apr 12, 2024
vincit-matu
force-pushed
the
fix-reservation-unit-state
branch
from
cf4ee48
to
fb2af51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
🎫 Tickets