Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the reservation comments field, if there is no comment #1496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't show the reservation comments field, if there is no comment #1496

wants to merge 1 commit into from

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • A reservation's comments label isn't rendered anymore when there was no comment to show
  • We now check also for "", in addition to null-check
  • Also includes some code-smell fixes for spa/reservations/[id]/index.tsx

🧪 Test plan

  • Check out a reservation which doesn't have comments (example)
  • There should not be a "Ratkaisun kommentti:" label without any value on the page

🎫 Tickets

  • TILA-3500

@vincit-matu
fix: don't show empty comments
190602c 
- check handlingDetails for empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincit-matu @joonatank