Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only selected unit reservationUnits as options in admin search filters #1508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • The unit filter and reservation unit filter use the new pageless endpoints when querying for options, so any automatic fetchMores etc are unnecessary even if there's over 100 results
  • If any units are selected in the unit-filter, only reservationUnits from the selected units are shown as options in the reservation unit filter.

🧪 Test plan

  • The admin page search filters now shows over 100 options if necessary (in practice only unit and reservation unit, but the others are unlikely to have over 100 entries)
  • Go to the reservation search in the admin pages (varaustoiveet/kaikki varaukset) and check that the reservation unit filter is fully populated (since no units are selected)
  • Select a unit from the unit multiselect, and check the reservation unit filter options: they only include options from the selected units

🎫 Tickets

  • TILA-3508, TILA-3627

@vincit-matu vincit-matu force-pushed the fix-admin-reservation-unit-filters branch 2 times, most recently from 3eabdc5 to e1c6ee5 Compare November 15, 2024 19:42
@vincit-matu vincit-matu force-pushed the fix-admin-reservation-unit-filters branch from e1c6ee5 to 40cff92 Compare November 15, 2024 19:44
@vincit-matu vincit-matu force-pushed the fix-admin-reservation-unit-filters branch from 40cff92 to 8b58d6c Compare November 15, 2024 19:48
@vincit-matu vincit-matu marked this pull request as ready for review November 15, 2024 19:49
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants