Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: front page search not working #1523

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: front page search not working #1523

merged 2 commits into from
Nov 19, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Nov 19, 2024 •
edited
Loading

🛠️ Changelog

  • Fix: front page text search param not applied correctly on route change.
  • Fix: search values can't be removed using the form (clear buttons or removing text) without adding / changing another value.

🧪 Test plan

  • Manual testing: front page search should include the text param.
  • Manual testing: search forms (both single and seasonal) should work normally (+ clearing values works).

🎫 Tickets

  • TILA-####

@joonatank joonatank merged commit 7e1e396 into main Nov 19, 2024
8 checks passed
@joonatank joonatank deleted the fix-front-page-search-not-working branch November 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@vincit-matu vincit-matu Awaiting requested review from vincit-matu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vergama