Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform UXDS library to Prettier & ESLint standards #120

Closed
maxatdetroit opened this issue Nov 27, 2023 · 1 comment · Fixed by #99, #101, #108, #113 or #123
Closed

Conform UXDS library to Prettier & ESLint standards #120

maxatdetroit opened this issue Nov 27, 2023 · 1 comment · Fixed by #99, #101, #108, #113 or #123
Assignees
@maxatdetroit
Labels
documentation Changes only affect the documentation good first issue Good for newcomers internal Changes only affect the internal API tests Add or improve existing tests

Comments

@maxatdetroit
Copy link
Member

Is your feature request related to a problem? Please describe.
We have a lot of places in our UX design system library jedgar1mx/COD-Design-System that have precarious javascript patterns (e.g. using != instead of !== or instantiated but unused variables).

Describe the solution you'd like
Put prettier and ESLint in place and enforce these standards for any new files. Go back and tackle the old issues as time permits.

This is a master issue to add prettier and ESLint into our CI workflow then tackle old issues as time permits.
@maxatdetroit maxatdetroit added documentation Changes only affect the documentation good first issue Good for newcomers internal Changes only affect the internal API tests Add or improve existing tests labels Nov 27, 2023
@maxatdetroit maxatdetroit self-assigned this Nov 27, 2023
This was linked to pull requests Nov 27, 2023
Enable ESLint; add ESLint/Prettier to CI #99
Merged
Fix card component lints & bug #101
Merged
Fix lints in icon element #108
Merged
Fix lints in button component #113
Merged
@maxatdetroit maxatdetroit mentioned this issue Nov 28, 2023
Merged
@maxatdetroit maxatdetroit linked a pull request Nov 28, 2023 that will close this issue
Resolve lints in all nav components #123
Merged
@maxatdetroit
Copy link
Member Author

Still some work to do here. I think github closed using a keyword here.

@maxatdetroit maxatdetroit reopened this Dec 1, 2023
@maxatdetroit maxatdetroit removed their assignment Apr 19, 2024
@maxatdetroit maxatdetroit mentioned this issue Apr 25, 2024
Merged
@maxatdetroit maxatdetroit linked a pull request Apr 25, 2024 that will close this issue
Resolve more ESLint errors #206
Merged
@maxatdetroit maxatdetroit self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxatdetroit maxatdetroit

Labels
documentation Changes only affect the documentation good first issue Good for newcomers internal Changes only affect the internal API tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
1 participant
@maxatdetroit