Resolve more ESLint errors #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxatdetroit
commented
Apr 25, 2024
| @@ -121,9 +120,7 @@ export default class FormCheckGroup extends HTMLElement { | |||
| while (next) { | |||
| if ( | |||
| next.getAttribute('data-type') === 'radio' || | |||
| // TODO: See CityOfDetroit/detroitmi#1099 | |||
| // eslint-disable-next-line no-undef | |||
| prev.getAttribute('data-type') === 'checkbox' | |||
There was a problem hiding this comment.
This was a bug. Probably a copy-paste error from the block above. prev is not defined in this scope.
jedgar1mx
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #120
This continues the work from #120. With the exception of one change where I found a bug (see comment on the PR) this PR is a non-operation performed via codemod.
I'm performing this refactor now because it cleans up the code a bit and makes the more substantial changes we're about to make in UXDS 2.0 easier and less error prone.
We'll merge this directly in to dev, then merge dev into branch 2.0.0-alpha1 so we have these changes in 2.0 as well.