Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import components top down instead of bottom up #135

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Import components top down instead of bottom up #135

merged 2 commits into from
Jan 8, 2024

Conversation

maxatdetroit
Copy link
Member

@maxatdetroit maxatdetroit commented Dec 28, 2023

Fix #134

See root cause of the issue and possible solutions in the issue #134

This PR:

  • Import outermost components (organisms) first, then inner components (molecules, atoms) to ensure outer elements are defined before inner elements just as they are typically parsed in the DOM.
  • Rebuild the production build files

As mentioned in issue #134 , a better (though more involved fix) will be to implement table-stacked as a reactive property that works regardless of the order of component definition, although I plan to do that as a followup since it will require a bit more time. This PR unblocks use of the table elements in production.

Testing

  1. Checkout demo branch demo.issue.134
  2. Load the demo HTML page that defers script execution: demo/demo-page-defer.html
  3. Ensure that table-stacked class is present on the table row in cod-table-row shadow DOM

Screenshot 2023-12-28 at 1 39 42 PM

@maxatdetroit maxatdetroit added the bug Something isn't working label Dec 28, 2023
@maxatdetroit maxatdetroit self-assigned this Dec 28, 2023
@jedgar1mx jedgar1mx merged commit 36d89c5 into dev Jan 8, 2024
3 checks passed
@maxatdetroit maxatdetroit mentioned this pull request Jan 12, 2024
@jedgar1mx jedgar1mx deleted the fix.134 branch February 6, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook works different from production build
2 participants