Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header background height #165

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix header background height #165

merged 1 commit into from
Feb 29, 2024

Conversation

maxatdetroit
Copy link
Member

Fix #164

Setting width and height to 100% was constraining the height of the pseudo-element to its containing block (which is the height of the content area of the pseudo-element).

Changes in this PR

  • Remove explicit width/height and let flex grow do its thing.

Testing

image

@maxatdetroit maxatdetroit added the bug Something isn't working label Feb 22, 2024
@maxatdetroit maxatdetroit self-assigned this Feb 22, 2024
@jedgar1mx jedgar1mx merged commit 2e047c0 into dev Feb 29, 2024
5 checks passed
@jedgar1mx jedgar1mx deleted the fix.164 branch February 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack headers not expanding
2 participants