-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup.Spinner #218
base: 2.0.0-alpha1
Are you sure you want to change the base?
Cleanup.Spinner #218
Conversation
[RFC] Create table v2 to resolve performance issues
…boolean attribute to the Alert component
Use common story arguments
Add Close Button to Alert Component
@maxatdetroit, I just wanted to clarify that #202 was the only issue that pertained to this component |
Yes, good clarification. That was correct when you asked, but I did notice while reviewing this PR that the storybook stories are setting missing controls to
Would you please update the Storybook story for the spinner to omit attributes if they're not set in the story (e.g. |
Also, all PRs for 201, 202, and 205 should be based on the
This is a case where a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplifies attribute naming conventions (removes data- prefix) as mentioned in issue #202