-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceButton Component Creation #290
base: dev
Are you sure you want to change the base?
Conversation
…ook test build fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely on the right track. We're going to have to think about how to handle accessibility requirements (e.g. aria attributes) inside the component, so feel free to think about that yourself as you're revising this PR. I'll also review for accessibility when I come back on the next PR review.
…ed styles, changed button to a and added href and service-button class, changed || to && in stories file
…so removed problem tests from stories file
I kept having issues with the other 2 tests I had. Do you have any test ideas? I was trying mock click, which kept clicking the button and sending it to the dummy link whenever I opened Storybook. And the other was check for something other than span it kept changing the layout of the component: @maxatdetroit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty close to done but needs a few tweaks.
…d prettier issues in 2 files
… issues in 1 file
Mobile
Desktop
Requirements
BUTTON WITHOUT HOVER:
BUTTON WITH HOVER:
ADD TESTS FOR COMPONENT
Verify that the title text is rendered correctly
Verify that the subtitle text is rendered correctly
Verify that the button changes color on hover
Check that the overlay effect appears on hover
Verify that the SVG appears on hover
Check that the SVG is positioned correctly (bottom right)
TEST RESULTS: