feat: update major dependencies #1589

ludtkemorgan · 2023-03-17T19:16:28Z

This PR addresses #1591

This change addresses the issue in full
This change addresses only certain aspects of the issue
This change is a dependency for another issue
This change has a dependency from another issue

Description

This upgrades several dependencies that have already been upgraded in core this includes:

Node from 14 to 18
Next to 12
React to 18
Cypress from 9 to 12

It also accomplishes the following:

removes storybook from detroit-ui-components
update all test ids to data-testid

How Can This Be Tested/Reviewed?

This touches every page so it is recommended to go to every page and do a quick check. These changes are already in and have been tested so we don't have to be as thorough, but there are some changes that are unique so a quick passover is recommended.

You will need to test locally since it has to have a new deployed version of the backend

Checklist:

Reviewer Notes:

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

netlify · 2023-03-17T19:16:34Z

❌ Deploy Preview for detroit-storybook-dev failed.

Name	Link
🔨 Latest commit	`10eab3d`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-storybook-dev/deploys/6430827c2d8a340008d238a4

netlify · 2023-03-17T19:16:35Z

✅ Deploy Preview for detroit-public-dev ready!

Name	Link
🔨 Latest commit	`22581b2`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-public-dev/deploys/64414c09a386fd0008287825
😎 Deploy Preview	https://deploy-preview-1589--detroit-public-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-17T19:16:35Z

✅ Deploy Preview for detroit-partners-dev ready!

Name	Link
🔨 Latest commit	`22581b2`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-partners-dev/deploys/64414c09aeab2c0008c578dc
😎 Deploy Preview	https://deploy-preview-1589--detroit-partners-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ludtkemorgan · 2023-04-12T18:42:23Z

sites/partners/src/components/listings/PaperListingForm/UnitsSummaryAmiForm.tsx

@@ -74,6 +74,12 @@ const UnitsSummaryAmiForm = ({
    [amiInfo, setAmiPercentageOptions]
  )

+  useEffect(() => {


There is an edge case only appearing on the cypress tests where the amiChartId is not being updated before the onChange event happens. By moving it to the useEffect we can guarantee that the order will happen correctly

ludtkemorgan · 2023-04-13T14:51:55Z

sites/partners/src/components/users/FormSignInAddPhone.tsx

@@ -0,0 +1,87 @@
+import React from "react"


This file and the ones below it were accidentally missed when pulling over the refactoring commits from core. Specifically where we pulled things out of ui-components and into the corresponding packages they are used in

emilyjablonski · 2023-04-14T22:42:11Z

Looking great! This is the only issue I've seen so far in that right hand panel on the housings basics page.

* feat: upgrade to node 19 and next 12 * fix: add netlify plugin * fix: add netlify plugin partners * fix: remove netlify plugins * fix: add netlify plugin to toml * Revert "fix: remove netlify plugins" This reverts commit 840b4a1. * fix: switch to node 16 * fix: update all places referencing node * Revert "fix: update all places referencing node" This reverts commit 9f13a5a. * Revert "fix: switch to node 16" This reverts commit 8acbfbe. * fix: re-installed with 18

ludtkemorgan · 2023-04-17T18:42:51Z

Looking great! This is the only issue I've seen so far in that right hand panel on the housings basics page.

Nice catch, there were also a couple of places where the markdown wasn't getting formatted. I've pushed up an update (remove new line below the RenderIf)

emilyjablonski

LGTM! Down to bash next week if we have time 🔌

ColinBuyck · 2023-04-18T23:54:23Z

Little thing but noticing that the "page not found" page is different. I definitely like the PR version better but just want to flag to make sure that its not pointing to any other issues

ColinBuyck · 2023-04-19T00:21:24Z

Also noticing when trying to add a new listing, I get an alert to resolve errors but don't see anything marked. Additionally, I get the following error in the console.

emilyjablonski · 2023-04-19T00:29:34Z

^ spooky to me that cypress didn't see this

ColinBuyck · 2023-04-19T07:09:50Z

Good point 👻 @emilyjablonski I revisited this after deleting node modules and reinstalling everything, and can't seem to reproduce the failed listing publish from before but without fail, the console errors show just from opening the add listing page.

ludtkemorgan · 2023-04-19T12:49:51Z

@ColinBuyck That console error is happening core as well. I created a ticket for it recently. bloom-housing#3392

ludtkemorgan · 2023-04-19T13:51:53Z

Little thing but noticing that the "page not found" page is different. I definitely like the PR version better but just want to flag to make sure that its not pointing to any other issues

Nice catch. This was because of a new error page that I added. I've updated it to the following. It's different than what is in prod, but I think this is what was originally intended

ColinBuyck

LGTM assuming Cypress test are just being being flakyyy 🫓

* feat: update major dependencies (#1589) * fix: update bull version (#1620) * 1577/download button can show and be non functional (#1621) * fix: display paper application button download when application is present * fix: hide redundant sections when data not provided * refactor: use paperMethod prop to decide if display download button * feat: uptake uic components (#1586) * fix: change reset to setValue for disableUnitsAccordion (#1628) * fix: various arabic layout fixes (#1629) * fix: run correct node version * fix: remove missed detroit-ui-components * fix: prettier fixes --------- Co-authored-by: Krzysztof Zięcina <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>

ludtkemorgan force-pushed the 3317/node branch from 0a70eea to 0c9d117 Compare March 20, 2023 16:54

ludtkemorgan force-pushed the 3317/node branch 6 times, most recently from 1a9bdd6 to 10eab3d Compare April 7, 2023 20:52

ludtkemorgan commented Apr 12, 2023

View reviewed changes

ludtkemorgan changed the title ~~3317/node~~ feat: update major dependencies Apr 12, 2023

ludtkemorgan marked this pull request as ready for review April 12, 2023 18:58

ludtkemorgan added the 2 reviews needed label Apr 13, 2023

ludtkemorgan commented Apr 13, 2023

View reviewed changes

ludtkemorgan and others added 14 commits April 17, 2023 13:29

fix: update travis config

d478d12

fix: update ui-component version

a8968ac

fix: change data test ids

6172be3

feat: upgrade react to 18

acf0c04

feat: more upgrades

35457b3

fix: typing fixes

46203a0

fix: update to latest ui-components

11d17f7

fix: update cypress

774aa4b

fix: update unit tests

d05b250

fix: update travis

047d1af

fix: detroit ui-component changes

5e8bdaa

feat: remove storybook

a8dcce8

fix: make ami change more determinant

29e5889

ludtkemorgan added 2 commits April 17, 2023 13:29

fix: add missed files from reorg

c248bf4

fix: markdown formatting

33c283c

ludtkemorgan force-pushed the 3317/node branch from a5935a5 to 33c283c Compare April 17, 2023 18:40

emilyjablonski approved these changes Apr 18, 2023

View reviewed changes

emilyjablonski added 1 review needed and removed 2 reviews needed labels Apr 18, 2023

fix: update error page styling

8cd78a9

ColinBuyck approved these changes Apr 19, 2023

View reviewed changes

ColinBuyck added ready to merge and removed 1 review needed labels Apr 19, 2023

fix test

22581b2

ludtkemorgan merged commit 8712e8c into dev Apr 20, 2023

ludtkemorgan deleted the 3317/node branch April 20, 2023 15:13

ludtkemorgan added a commit that referenced this pull request Jul 24, 2023

feat: update major dependencies (#1589)

71f2613

ludtkemorgan mentioned this pull request Jul 24, 2023

release: 2024-07-24 #1630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update major dependencies #1589

feat: update major dependencies #1589

ludtkemorgan commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading

ludtkemorgan Apr 12, 2023

ludtkemorgan Apr 13, 2023

emilyjablonski commented Apr 14, 2023

ludtkemorgan commented Apr 17, 2023

emilyjablonski left a comment

ColinBuyck commented Apr 18, 2023

ColinBuyck commented Apr 19, 2023

emilyjablonski commented Apr 19, 2023

ColinBuyck commented Apr 19, 2023

ludtkemorgan commented Apr 19, 2023

ludtkemorgan commented Apr 19, 2023

ColinBuyck left a comment

feat: update major dependencies #1589

feat: update major dependencies #1589

Conversation

ludtkemorgan commented Mar 17, 2023 • edited Loading

Description

How Can This Be Tested/Reviewed?

Checklist:

Reviewer Notes:

On Merge:

netlify bot commented Mar 17, 2023 • edited Loading

❌ Deploy Preview for detroit-storybook-dev failed.

netlify bot commented Mar 17, 2023 • edited Loading

✅ Deploy Preview for detroit-public-dev ready!

netlify bot commented Mar 17, 2023 • edited Loading

✅ Deploy Preview for detroit-partners-dev ready!

ludtkemorgan Apr 12, 2023

Choose a reason for hiding this comment

ludtkemorgan Apr 13, 2023

Choose a reason for hiding this comment

emilyjablonski commented Apr 14, 2023

ludtkemorgan commented Apr 17, 2023

emilyjablonski left a comment

Choose a reason for hiding this comment

ColinBuyck commented Apr 18, 2023

ColinBuyck commented Apr 19, 2023

emilyjablonski commented Apr 19, 2023

ColinBuyck commented Apr 19, 2023

ludtkemorgan commented Apr 19, 2023

ludtkemorgan commented Apr 19, 2023

ColinBuyck left a comment

Choose a reason for hiding this comment

ludtkemorgan commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading

netlify bot commented Mar 17, 2023 •

edited

Loading