api, tests: streamline invoke return types #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
test_*
functions ofChainFacade
directly return the actual result of the called method on the smart contract. Which is very convenient when only using test invokes, but makes it inconvenient when switching betweeninvoke_
andtest_invoke
because now the return type changed.Personally when writing code that ends up persisting to chain (via
invoke
) I start off withtest_invoke
(also with debugging) before swapping it over. By streamlining the return types one does not have to change the result handling code.Changes in this PR
test_invoke*
now return anInvokeReceipt
just like regularinvoke*
callsinvoke_multi
andinvoke_multi_raw
returnInvokeReceipt[Sequence]
instead ofSequence