Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to include holiday footnote asterisk #1354

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Update README.md to include holiday footnote asterisk #1354

merged 7 commits into from
Mar 5, 2024

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Feb 16, 2024 •
edited by github-actions bot
Loading

@kaise-lafrai kaise-lafrai requested a review from a team as a code owner February 16, 2024 18:09
@kaise-lafrai kaise-lafrai linked an issue Feb 16, 2024 that may be closed by this pull request
Purpose of the asterisk at the end of each of the holiday dates #1353
Closed
@kaise-lafrai kaise-lafrai self-assigned this Feb 16, 2024
@kaise-lafrai
Copy link
Contributor Author

The 2 links found in the pipeline tests to reach a 403 is not correct. I tested manually and both those links work

FILE: ./common-practices-tools/security/README.md
[✖] http://askubuntu.com/questions/57572/how-to-delete-files-in-secure-manner → Status: 403

ERROR: 1 dead links found!
[✖] http://askubuntu.com/questions/57572/how-to-delete-files-in-secure-manner → Status: 403

@dmundra
Copy link
Collaborator

dmundra commented Feb 19, 2024

The 2 links found in the pipeline tests to reach a 403 is not correct. I tested manually and both those links work

FILE: ./common-practices-tools/security/README.md
[✖] http://askubuntu.com/questions/57572/how-to-delete-files-in-secure-manner → Status: 403

ERROR: 1 dead links found!
[✖] http://askubuntu.com/questions/57572/how-to-delete-files-in-secure-manner → Status: 403

Yup I fixed that in #1356

@grugnog grugnog enabled auto-merge (squash) March 4, 2024 23:52
@grugnog grugnog merged commit 3e7ea6a into master Mar 5, 2024
11 checks passed
@grugnog grugnog deleted the Add-asterisk-back-to-the-holiday-footnote branch March 5, 2024 00:19
dmundra added a commit that referenced this pull request Mar 5, 2024
@kaise-lafrai @dmundra
Update README.md to include holiday footnote asterisk (#1354)
286d4f5 
* Update README.md to include holiday footnote asterisk

* Update README.md to remove text so that it is grammatically correct.

---------

Co-authored-by: Daniel Mundra <[email protected]>
TheBoatyMcBoatFace pushed a commit that referenced this pull request Jun 13, 2024
@kaise-lafrai @dmundra @TheBoatyMcBoatFace
Update README.md to include holiday footnote asterisk (#1354)
f3e4ecc 
* Update README.md to include holiday footnote asterisk

* Update README.md to remove text so that it is grammatically correct.

---------

Co-authored-by: Daniel Mundra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grugnog grugnog grugnog approved these changes

Assignees

@kaise-lafrai kaise-lafrai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purpose of the asterisk at the end of each of the holiday dates
4 participants
@kaise-lafrai @dmundra @grugnog @civicactionsbot