This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
Fix deprecation when passing null to esc_url
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #123 and also in my logs
PHP Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in .../httpdocs/wp-includes/formatting.php on line 4414esc_urlis throwing a deprecation.Description
Return an empty string on
esc_url( null ).This is the current behavior of
esc_urland in PHP>=8.1 is throwing a deprecation.Note that
esc_url( array() )throws a fatal and that behavior is left intentionally unchanged.How has this been tested?
Local testing and unit test.
Types of changes
Closes #123.