Remove Accordion Script

[KTS915]

Following PR #197, there is no longer any need for the accordion script. This PR therefore removes it from the JS folder in wp-admin and removes the function calling it from template.php in wp-admin/includes

I have tested this on my own localhost test install. I have also grepped to find all instances of the accordion code being used in the admin, but I have found it only in the template.php file.

[mattyrob]

I've done a little testing and the Menu accordions no longer work within Customizer once the dependency is removed:

[KTS915]

Good catch, @mattyrob ! I never use the Customizer so never thought of that. I'll see if I can make that work using the details tag instead, like the regular nav-menu, so that we can remove this script.

[KTS915]

@mattyrob, I've now taken a look and the menu accordions in the Customizer are working fine for me. Indeed, looking at the script-loader.php file, it's clear that the accordion script isn't used there. The relevant lines are these:

$scripts->add( 'customize-nav-menus', "/wp-admin/js/customize-nav-menus$suffix.js", array( 'jquery', 'wp-backbone', 'customize-controls', 'nav-menu', 'wp-sanitize' ), false, 1 ); $scripts->add( 'customize-preview-nav-menus', "/wp-includes/js/customize-preview-nav-menus$suffix.js", array( 'jquery', 'wp-util', 'customize-preview', 'customize-selective-refresh' ), false, 1 );

No mention of accordion there. I'm wondering if you've removed the wrong accordion version for your test. (As you can see in this PR, I made that mistake myself initially, and removed the one associated with jQuery UI.)

[mattyrob]

@KTS915 - I'm checked out on this branch and when I get to the screen that I posted a screen grab off before, in Safari and FF, I cannot get the items in the accordion under the "Add Items" to open.

By reverting the changes in commit 06e6037, that section works again.

I should say that anything currently in the Menu seems to work fine.

[KTS915]

@mattyrob Thanks, I managed to replicate the problem and have now pushed some changes to make it work. Specifically, I have added the details and summary tags, as with the regular nav menu, and deleted one line of CSS that would prevent the content of each section from being displayed.

[xxsimoxx]

I'm getting wrong icon in customizer.

The problem started in #197 but maybe can be fixed in this PR.

[mattyrob]

@xxsimoxx - I think I may have fixed the icon issue but was working on develop and pushed it by mistake - so I hope it was right.
If not we can revert and do more testing on this PR.

[xxsimoxx]

@mattyrob the commit in develop fixed the issue.

[xxsimoxx]

Looks good to me.

[mattyrob]

Is there one more things for this is to consider on this PR, removing src/wp-admin/js/accordion.js from core?

[KTS915]

Lol, of course I should have deleted that file! Duh! Now done.