This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
WP-r55607: Comments: Use wp_cache_get_multiple in WP_Comment_Query #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `fill_descendants` method in `WP_Comment_Query`, there is a loop the calls `wp_cache_get` to get `child comments. Instead of getting one key at a time, use `wp_cache_get_multiple` and get all keys at once. WP:Props spacedmonkey, tillkruess, mukesh27. Fixes https://core.trac.wordpress.org/ticket/57803. Conflicts: - src/wp-includes/class-wp-comment-query.php --- Merges https://core.trac.wordpress.org/changeset/55607 / WordPress/wordpress-develop@c46a30eb1f to ClassicPress.
|
Has two approvals, merging in preparation for v2 repository migration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comments: Use wp_cache_get_multiple in WP_Comment_Query.
In the fill_descendants method in WP_Comment_Query, there is a loop the calls wp_cache_get to get child comments. Instead of getting one key at a time, use wp_cache_get_multiple` and get all keys at once.
Props spacedmonkey, tillkruess, mukesh27.
https://core.trac.wordpress.org/changeset/55607
Motivation and context
Backport of upstream efficiency enhancement
How has this been tested?
This is a backport, local tests have been passing.
Screenshots
N/A
Types of changes