This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
WP-r55888: Script Loader: Improve performance of wp_maybe_inline_styles function. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es function. The `wp_maybe_inline_styles` function is called twice on the average page load. On it's second run however, it did not check to see if the style had already been processed on the first run. This resulted in calling `filesize` and `get_file_contents` unnecessarily, which was bad for performance. Now, the loop around the queued styles, checks to see if the source is set to false, meaning it has already been processed. This change also replaces calls to `filesize` with the core function `wp_filesize`, which improves extensibility. WP:Props spacedmonkey, flixos90, peterwilsoncc, joemcgill. Fixes https://core.trac.wordpress.org/ticket/58394. Conflicts: - tests/phpunit/tests/dependencies/styles.php --- Merges https://core.trac.wordpress.org/changeset/55888 / WordPress/wordpress-develop@582ddb82f4 to ClassicPress.
…n wp_maybe_inline_styles. Add a check in `wp_maybe_inline_styles` to check that style is registered before processing items in queue. It is possible that developers may have called `wp_deregister_style`, unregistering style but the style still be in the queue to be processed. Without this check, typing to access the `src` property would result in a notice error. Follow on from https://core.trac.wordpress.org/changeset/55888. WP:Props spacedmonkey, flixos90, dd32, kebbet. See https://core.trac.wordpress.org/ticket/58394. --- Merges https://core.trac.wordpress.org/changeset/55909 / WordPress/wordpress-develop@559e6cecf4 to ClassicPress.
|
Has two approvals, merging in preparation for v2 repository migration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Script Loader: Improve performance of wp_maybe_inline_styles function.
The wp_maybe_inline_styles function is called twice on the average page load. On it's second run however, it did not check to see if the style had already been processed on the first run. This resulted in calling filesize and get_file_contents unnecessarily, which was bad for performance. Now, the loop around the queued styles, checks to see if the source is set to false, meaning it has already been processed. This change also replaces calls to filesize with the core function wp_filesize, which improves extensibility.
Props spacedmonkey, flixos90, peterwilsoncc, joemcgill.
https://core.trac.wordpress.org/changeset/55888
Motivation and context
Backport of upstream efficiency enhancement
How has this been tested?
This is a backport, local tests have been passing.
Screenshots
N/A
Types of changes