Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advection equation solution (part of QInnovision 2025 challenge) #725

Closed
wants to merge 5 commits into from

Conversation

quantotto
Copy link

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NadavClassiq
Copy link
Collaborator

Hello @quantotto!

Thank you for contributing your work from the Qinnovation hackathon!
I saw that the test failed due to a "broken" link, which is actually working, so I allowed it to pass the test.

Can you please rebase your branch on top of the upstream main (or your local main after updating it)?
This should resolve the issue.

Thanks again!

@NadavClassiq
Copy link
Collaborator

Hello @quantotto!

How are you?
Please rebase and move the files to the "community folder"?
We are looking forward to including your contribution!

@quantotto
Copy link
Author

Thanks @NadavClassiq

What should be the directory structure under community? I see only two folders there (Qclass_2024 and basic_examples).
Thanks!

@ravidalon ravidalon mentioned this pull request Jan 29, 2025
@NadavClassiq
Copy link
Collaborator

This PR is blocked due to the use of merge rather than rebase. New PR was opened and merged: #743
(same contributor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants