Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Morse Code Decoder #1

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

ClaudiaRojasSoto
Copy link
Owner

Description

This pull request introduces a series of methods that fulfill the following requirements:

General Requirements

  • No linter errors.
  • Gitflow was used.
  • Work was documented in a professional manner.

Ruby Requirements

  • Best practices for Ruby were followed.

Project Requirements

  • Decode a Morse Character: A method was created to decode a Morse character, taking a string and returning the corresponding character in uppercase.
  • Decode a Morse Word: A method was created to decode an entire word in Morse, taking a string and returning the string representation.
  • Decode an Entire Morse Message: A method was created to decode an entire Morse message, taking a string and returning the string representation. Each word is separated by 3 spaces.
  • Reuse of Methods: Ensured that the code is DRY by reusing methods wherever possible.
  • Decoding a Real Message: The code was used to decode the message from an old bottle: .- -... --- -..- ..-. ..- .-.. .-.. --- ..-. .-. ..- -... .. . ....

Please review our work, and give us feedback to improve.
Greetings,
@CesarHerr
@ClaudiaRojasSoto

@ClaudiaRojasSoto ClaudiaRojasSoto added the enhancement New feature or request label Aug 22, 2023
Copy link

@AbelG101 AbelG101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClaudiaRojasSoto & @CesarHerr 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉 🥳🥇

Highlights

  • Morse code is correctly decoded ✔
  • Great code organization with comments ✔
  • Correct use of Git Flow ✔
  • Linter check is passing ✔
  • Descriptive PR title with an amazing summary ✔

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ClaudiaRojasSoto
Copy link
Owner Author

Thank you @AbelG101!

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit a15c0cd into develop Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants