Skip to content

Commit

Permalink
Merge pull request #291 from CleanCut/release-env
Browse files Browse the repository at this point in the history
Set environment name for the releases
  • Loading branch information
sodul authored Feb 15, 2024
2 parents b34629f + cf1b1de commit 9e9e5cf
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: Upload release to PyPI Test
runs-on: ubuntu-latest
environment:
name: pypi
name: release-test
url: https://test.pypi.org/p/green
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.event_name == 'release'
runs-on: ubuntu-latest
environment:
name: pypi
name: release
url: https://pypi.org/p/green
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#### Date TBD

# Version 4.0.1
#### 14 Feb 2024
#### 15 Feb 2024

Note that we are explicitly flagging Python 3.12.1 as incompatible due to a regression
that was fixed in 3.12.2.
Expand Down
4 changes: 2 additions & 2 deletions release.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ Steps to Release

2. Push and merge to the main branch.

3. Trigger the Release Test workflow in GitHub Actions. Optional but recommended.
3. Trigger the Release Test workflow in GitHub Actions then approve the run on the release-test environment. Optional but recommended.

4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest.
4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest after beeing approved to run.

0 comments on commit 9e9e5cf

Please sign in to comment.