New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Fluid Task Default Consume to false #124

Merged

Rongmario merged 1 commit into CleanroomMC:1.12 from WaitingIdly:fluid-task-default-consume

Nov 4, 2024

Collaborator

WaitingIdly commented Oct 13, 2024

changes in this PR:

set fluid task default to not consume
not consuming by default is a more logical position than consuming by default
fixes a situation where previously removing the value from the task would result in it being set to false, but due to the creation of a default fallback value, it would be set to true when removed instead.


          set fluid task default to not consume

c122d8c

WaitingIdly added the enhancement label

MCTian-mi commented Nov 4, 2024

shit why this isn't merged in 4.2.5

Rongmario approved these changes

View reviewed changes

Rongmario merged commit 3296254 into CleanroomMC:1.12

2 checks passed

WaitingIdly deleted the fluid-task-default-consume branch

November 4, 2024 21:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels