react-query for blocklist fetching and caching #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thieflord06
approved these changes
Nov 24, 2024
|
@noahm Please check what's breaking Ag grid view Screen.Recording.2024-11-24.at.10.43.04.AM.mov |
|
@AshishDhama Nice catch. Oddly the table view seems to completely break when the search header is taken out of the layout... Looks like something weird about a flex or grid based layout quirk. |
|
Actually... my auto-loading approach doesn't work at all in the table view. Gotta work on this more tomorrow if that's also important to keep enabled. |
|
@thieflord06 Could you please give more context for the ag-grid view, the current feature doesn’t justify ag-grid usage. It's a big library. |
|
@mihailik Can you give context? |
|
After discussing in the discord a bit, i've gone ahead and removed the table view in this PR. We can explore restoring it in the future. |
AshishDhama
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches over to react-query (aka tanstack query) to manage fetch/cache behavior of blocklists. Only one page will load initially. If more pages are available, the next will begin loading after a user scrolls to the bottom of the current list.
This also removes the search functionality, as it will be inaccurate as long as we aren't loading the complete list of blocks in the client. In the future we can restore search behavior somehow, ideally via server-side call, but perhaps conditionally whenever all pages have been loaded?
Closes #80
Closes #59
Begins progress on #122