Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap list descriptions instead of elipses #264

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Wrap list descriptions instead of elipses #264

merged 1 commit into from
Jan 14, 2025

Conversation

HYDRO2070
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clearsky-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:11pm

@thieflord06
Copy link
Member

Passes functionality checks.

@thieflord06 thieflord06 enabled auto-merge January 13, 2025 20:01
noahm
noahm approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine. it may throw a wrench in #255 by making the items in the list variable height.

@thieflord06 thieflord06 merged commit de56711 into ClearskyApp06:dev Jan 14, 2025
2 checks passed
@thieflord06 thieflord06 mentioned this pull request Jan 14, 2025
Merged
@thieflord06 thieflord06 linked an issue Jan 14, 2025 that may be closed by this pull request
Wrap list descriptions instead of elipses #262
Closed
@tb38r tb38r mentioned this pull request Jan 14, 2025
Merged
@thieflord06 thieflord06 mentioned this pull request Jan 15, 2025
Merged
7 tasks
thieflord06 added a commit that referenced this pull request Jan 26, 2025
@thieflord06
Without virtualisation (#266)
1deef25 
Withheld working on the virtualisation element to get a viable working
product out.
Throttled getListSize to prevent server overload.
Updated with css changes from #264.
List count appears to the right of of the list name.
resolves #255.

![Screenshot 2025-01-14 at 17 38
38](https://github.com/user-attachments/assets/bf70d00d-5c2a-4861-92b6-110a9ca71258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahm noahm noahm approved these changes

@thieflord06 thieflord06 thieflord06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap list descriptions instead of elipses
3 participants
@HYDRO2070 @thieflord06 @noahm