Make profile top better in mobile mode #299
Conversation
|
@seanmunson is attempting to deploy a commit to the thieflord06's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good. |
Head branch was pushed to by a user without write access
|
This looks and feels a lot better. |
|
Yup this looks a lot better. I need to do a bit more testing with the latest dev merged in, since this still has all the old double scrolling issues. |
There was a problem hiding this comment.
Updated to the latest from dev just to check first, but the issue is still there: while the profile info panel is visible there's a large amount of extra horizontal scroll available for some reason. Nothing immediately stood out to me, so I'm not really sure why.
|
It looks like it has something to do with the 'x' button. |
|
I just played around A LOT with trying to get the 'x' closer to the top of the container, with no luck. I guess it'll have to do as is. |
There was a problem hiding this comment.
For desktop we need to change back to the old way that handle history was being shown (In the bottom left corner). I think this was changed in #294
…o 296-make-profile-collapsable
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Updates to the extra profile look great. This also changes the way scrolling works again, to fix all the profile header and tabs to the top of the screen which I disagree with (at least in the form it is here, best to continue discussing in frontend or design channels)... but it seems that may have been an unstated goal of this PR that I was just unaware of? Not blocking this, but just wanted to call out the extra changes that don't seem described elsewhere.
in mobile mode, "details" now becomes a pop-out that can be triggered by tapping the (i) button in the header
#296