Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: add schema test for uncommented default config #1484

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Add a test for an uncommented variant of the default config file.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the add_schema_test_for_uncommented_default branch 4 times, most recently from 792e2a6 to 5658c5f Compare June 17, 2024 01:25
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 51.69492% with 57 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (7666a09) to head (068fa73).

Files Patch % Lines
src/main.rs 3.33% 29 Missing ⚠️
src/options/config/process.rs 70.58% 25 Missing ⚠️
src/options.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   40.83%   40.84%   +0.01%     
==========================================
  Files         102      102              
  Lines       17547    17620      +73     
==========================================
+ Hits         7165     7197      +32     
- Misses      10382    10423      +41     
Flag Coverage Δ
macos-12 36.21% <51.69%> (+0.02%) ⬆️
ubuntu-latest 42.79% <51.69%> (+<0.01%) ⬆️
windows-2019 36.35% <51.69%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the add_schema_test_for_uncommented_default branch 4 times, most recently from b20c001 to 6a1dd27 Compare June 17, 2024 01:59
@ClementTsang ClementTsang force-pushed the add_schema_test_for_uncommented_default branch from 6a1dd27 to b51433c Compare June 17, 2024 02:03
@ClementTsang ClementTsang force-pushed the add_schema_test_for_uncommented_default branch from 1110d1f to c133e58 Compare June 17, 2024 04:40
@ClementTsang ClementTsang force-pushed the add_schema_test_for_uncommented_default branch from c133e58 to 068fa73 Compare June 17, 2024 04:41
@ClementTsang ClementTsang merged commit 3602429 into main Jun 17, 2024
36 checks passed
@ClementTsang ClementTsang deleted the add_schema_test_for_uncommented_default branch June 17, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant