Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: show N/A for Nvidia GPUs if we detect one but can't get temps #1557

Merged
merged 3 commits into from
Aug 11, 2024

missed one

199d95e
Select commit
Loading
Failed to load commit list.
Merged

other: show N/A for Nvidia GPUs if we detect one but can't get temps #1557

missed one
199d95e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 11, 2024 in 0s

35.96% (-5.45%) compared to c65121c

View this Pull Request on Codecov

35.96% (-5.45%) compared to c65121c

Details

Codecov Report

Attention: Patch coverage is 58.53659% with 17 lines in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (c65121c) to head (199d95e).

Files Patch % Lines
src/data_collection/nvidia.rs 0.00% 8 Missing ⚠️
src/app/filter.rs 71.42% 6 Missing ⚠️
src/data_collection/network/sysinfo.rs 0.00% 1 Missing ⚠️
src/data_collection/temperature/sysinfo.rs 0.00% 1 Missing ⚠️
src/options.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c65121c) and HEAD (199d95e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c65121c) HEAD (199d95e)
ubuntu-latest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   41.41%   35.96%   -5.45%     
==========================================
  Files         114      108       -6     
  Lines       17847    16844    -1003     
==========================================
- Hits         7391     6058    -1333     
- Misses      10456    10786     +330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.