Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added staff for #19 and contact page for #21 #26

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

charlestruluck
Copy link
Collaborator

No description provided.

@charlestruluck
Copy link
Collaborator Author

charlestruluck commented Mar 15, 2022

Also includes issue #21 now from PR #27

@charlestruluck charlestruluck changed the title added staff for #19 added staff for #19 and contact page for #21 Mar 15, 2022
@charlestruluck charlestruluck linked an issue Mar 15, 2022 that may be closed by this pull request
Copy link
Member

@Exper1mental Exper1mental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing is you need to resolve the bot crashing issue. Ideally, Gaming and Support rosters should be on separate pages but that can be done later.

roster_machine.js Show resolved Hide resolved
@@ -29,6 +30,31 @@
</div>
<%});%>
</div>
<hr>
<h1>Our Support Teams</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support Teams should be on a separate page so there isn't so much content to scroll through. Could be in a dropdown menu from Rosters header listing Gaming Roster and Support Roster.

@@ -4,6 +4,7 @@
<main class="mdl-layout__content">
<div class="mdl-typography--text-center clemson-esports">
<h1>Contact Us</h1>
<iframe src="https://docs.google.com/forms/d/e/1FAIpQLSfxFgY6umfhi8tUG-4xxVykFsRBZB2J6OLxmEeQgC-bzGxvJg/viewform?embedded=true" width="640" height="1200" frameborder="0" marginheight="0" marginwidth="0">Loading…</iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to change to dark colors but this is a good starting point for us.

Fixed issue where roster_machine.js script would repeatedly query Discord for the entire server's member list, eventually leading to a timeout and crash of the script.
The Discord roster bot now runs in a child process. This prevents the rest of the website from crashing if the roster bot crashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contact Page and Form
2 participants