Skip to content
This repository was archived by the owner on Nov 4, 2022. It is now read-only.

Add header access-control-allow-header to '*' in userAPI response. #101

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

TomChv
Copy link
Collaborator

@TomChv TomChv commented Mar 6, 2022

Description

To fix session issue with flutter, an issue recommend to explicitly send that
header.
Since it doesn't appear in Flutter web, I've explicitly set it in my response.

cfug/dio#1027 (comment)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have added sufficient documentation in the code

To fix session issue with flutter, an issue recommend to explicitly send that
header.
Since it doesn't appear in Flutter web, I've explicitly set it in my response.

Signed-off-by: Vasek - Tom C <[email protected]>
@TomChv TomChv added bug Something isn't working backend/user All about user API labels Mar 6, 2022
@TomChv TomChv requested a review from 0xpanoramix March 6, 2022 15:43
@TomChv TomChv self-assigned this Mar 6, 2022
Copy link
Collaborator

@0xpanoramix 0xpanoramix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@TomChv TomChv merged commit d53705a into develop Mar 6, 2022
@TomChv TomChv deleted the user-api/fix-response-header branch March 6, 2022 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend/user All about user API bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants