replace master references with default branch name fetched from github api #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andruwm
requested review from
a team and
sriram-clever
and removed request for
a team
|
Tagging security since this also adds new credentials to the CI pipeline. |
andruwm
reviewed
Nov 11, 2024
| if [[ $BRANCH != "master" ]]; then | ||
| : ${CIRCLE_PROJECT_REPONAME?"Missing required env var"} | ||
| REPO=$CIRCLE_PROJECT_REPONAME | ||
| : ${GITHUB_TOKEN?"Missing required env var"} |
There was a problem hiding this comment.
Would this token need to be added and rotated in all CI projects?
| DEFAULT_BRANCH=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \ | ||
| "https://api.github.com/repos/Clever/$REPO" | jq -r '.default_branch') | ||
|
|
||
| if [[ $BRANCH != $DEFAULT_BRANCH ]]; then | ||
| echo "Skipping sync for non-master branch" |
There was a problem hiding this comment.
The text here should also get updated, so that if the primary branch is ever named main this error message wouldn't be confusing.
| @@ -14,7 +16,7 @@ echo "2) Run the following command, replacing CIRCLE_API_TOKEN with the token fr | |||
| echo "curl -u CIRCLE_API_TOKEN: \\ | |||
| -X POST \\ | |||
| --header \"Content-Type: application/json\" -d '{ | |||
| \"branch\": \"master\", | |||
| \"branch\": \"${DEFAULT_BRANCH}\", | |||
There was a problem hiding this comment.
Is the plan to accompany this with catapult changes? This would probably not behave as expected with just the CI changes if a team were to change their primary branch name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://clever.atlassian.net/browse/DD-5739
Overview
Testing changes to no longer reference master in favor of referencing the default branch returned from the github API.
Testing
Default branch correctly outputs master for the ci-scripts repo
Rollout