-
Notifications
You must be signed in to change notification settings - Fork 11
Add support for obtaining sync tokens #43
base: master
Are you sure you want to change the base?
Conversation
Promises/A+ support
I sure would like to hear something regarding this pull request. Does it encompass too much? Do you want/need me to split it up into separate pull requests? Are there other issues you see with regard to the functionality provided? Ignoring pull requests for nearly a week does not encourage people to contribute to your project. |
Hi @jloveridge - my name's Jonah, I'm the engineering manager for our Apps team. I'm really sorry for the delay. We really appreciate the contribution. Back to school is a busy time for us (as I'm sure it is for you), so we're not currently prioritizing improvements to our client libraries. That being said, the change you've proposed here is definitely on our roadmap. I'd encourage you to keep using your fork for now, and we'll circle back with you once we're ready to make this change! |
@jonahkagan thanks for the update. I will definitely continue to use my fork. I also wanted to let you know the token info endpoint doesn't appear to work. I always get back a 401 error when I make a request to that service. |
@jloveridge thanks for raising the 401 error issue. Can you email a report of the issue to [email protected] to get help troubleshooting? |
I will submit an issue to tech-support. However, I don't need help troubleshooting the problem as the issue is outside of my control. |
Adds
OAuth
class andme
method to the exports. The intent is to allow someone to implement their Instant Login and Secure Sync with the same library.Also adds support for API usage via promises.
Support for bring your own promise (BYOP) is also implemented. By default the promises used will be Q promises but can be easily changed to bluebird, or any other compliant library, if you so choose.