add remaining diagnostics to the new diagnostics package

[szy21]

Purpose

Add EDMFX diagnostics and add some default diagnostics when running simulations with EDMFX. I think this includes all the important diagnostics we want to have.

To-do

• Check if the diagnostics are physically correct

Content

---

• I have read and checked the items on the review checklist.

[Sbozzolo]

Looks good!

My main comment (other than the tiny details below) is that you the "comment" field in your variables is not really useful since you just paraphrase the long_name.

Maybe we can copy and paste the comments from the airtable with all the CMIP quantities?

[szy21]

Maybe we can copy and paste the comments from the airtable with all the CMIP quantities?

All the EDMFX specific diagnostics don't have a corresponding variable in the CMIP table, as they don't use the same convection scheme in CMIP. The comments for all updraft variables (diagnostics ending with up) are mostly to just describe that the diagnostics is for the first updraft. The comments for environment variables are basically the long_name, maybe I can just remove them?

[Sbozzolo]

Maybe we can copy and paste the comments from the airtable with all the CMIP quantities?

All the EDMFX specific diagnostics don't have a corresponding variable in the CMIP table, as they don't use the same convection scheme in CMIP. The comments for all updraft variables (diagnostics ending with up) are mostly to just describe that the diagnostics is for the first updraft. The comments for environment variables are basically the long_name, maybe I can just remove them?

When I look the table, I see for example for cli:

Includes both large-scale and convective cloud. Calculate as the mass of cloud liquid water in the grid cell divided by the mass of air (including the water in all phases) in the grid cells. Precipitating hydrometeors are included ONLY if the precipitating hydrometeors affect the calculation of radiative transfer in model.

I don't know how much detail we should have, but I think that having more is better than having less (especially if the variable is never going to change).

[szy21]

When I look the table, I see for example for cli:

Includes both large-scale and convective cloud. Calculate as the mass of cloud liquid water in the grid cell divided by the mass of air (including the water in all phases) in the grid cells. Precipitating hydrometeors are included ONLY if the precipitating hydrometeors affect the calculation of radiative transfer in model.

I don't know how much detail we should have, but I think that having more is better than having less (especially if the variable is never going to change).

Oh, right, I thought you meant the EDMFX variables. Yes, I can add more comments to variables like clw and cli. One reason I didn't add it is that the comments from the table don't apply to our model yet. For example, for cli, we don't have convective cloud, or precipitating hydrometeors. But maybe we can just add the comments and change how the diagnostics are calculated later?

[Sbozzolo]

When I look the table, I see for example for cli:

Includes both large-scale and convective cloud. Calculate as the mass of cloud liquid water in the grid cell divided by the mass of air (including the water in all phases) in the grid cells. Precipitating hydrometeors are included ONLY if the precipitating hydrometeors affect the calculation of radiative transfer in model.

I don't know how much detail we should have, but I think that having more is better than having less (especially if the variable is never going to change).

Oh, right, I thought you meant the EDMFX variables. Yes, I can add more comments to variables like clw and cli. One reason I didn't add it is that the comments from the table don't apply to our model yet. For example, for cli, we don't have convective cloud, or precipitating hydrometeors. But maybe we can just add the comments and change how the diagnostics are calculated later?

I think we should describe what we have, and update the description when we update the diagnostic.

[szy21]

@Sbozzolo I updated the comment of several variables following the CMIP air table, and removed the comment of some variables where they are similar to the long name. I also set the default EDMF diagnostics to daily average, and included an example yaml file in ci that calculates 10-min instantaneous EDMF diagnostics. The results look physical. Would you like to take another look?

[Sbozzolo]

@Sbozzolo I updated the comment of several variables following the CMIP air table, and removed the comment of some variables where they are similar to the long name. I also set the default EDMF diagnostics to daily average, and included an example yaml file in ci that calculates 10-min instantaneous EDMF diagnostics. The results look physical. Would you like to take another look?

It looks good to me. The only thing: could you split the extremely long strings to multiline strings?

Also, I didn't realize how many EDMF examples we are running. In the future, if we want the whole suite of diagnostics for all the EMDF examples, we will probably have to define them as default in the code. (But this is good for now).

[szy21]

It looks good to me. The only thing: could you split the extremely long strings to multiline strings?

I changed some of the comment to multiline strings. Is that what you mean?

Also, I didn't realize how many EDMF examples we are running. In the future, if we want the whole suite of diagnostics for all the EMDF examples, we will probably have to define them as default in the code. (But this is good for now).

Yeah, I think it would be good if we don't need to specify them for each job. I wonder if the config can take multiple yaml files now (it could before I think). If so, we can have one common diagnostic yaml file for the current edmf examples.

[szy21]

bors r+

[bors]

Build failed:

• buildkite/climaatmos-ci

[szy21]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climaatmos-ci
• ci 1.9 - macOS-latest
• ci 1.9 - ubuntu-latest
• docbuild
• format

[simonbyrne]

Part of #2198