Sync NetCDF file at every write #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change essentially disables the internal buffer in the NetCDF library. With this change, every time something has to be written to disk, it is immediately written (as opposed to buffering writes). This ensures that datasets are always written and no data is lost, but comes to a performance cost. This was already the default behavior for GPU runs, so this change only affects CPU runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change essentially disables the internal buffer in the NetCDF library. With this change, every time something has to be written to disk, it is immediately written (as opposed to buffering writes).
This ensures that datasets are always written and no data is lost, but comes to a performance cost.
This was already the default behavior for GPU runs, so this change only affects CPU runs
Closes CliMA/ClimaCoupler.jl#858