Do not add ᶜ∇²tke⁰ to cache if not needed #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/tke_diag
branch
2 times, most recently
from
d7ee737 to
55c86c7
Compare
szy21
reviewed
Sep 23, 2024
Sbozzolo
force-pushed
the
gb/tke_diag
branch
from
55c86c7 to
49b8be3
Compare
szy21
approved these changes
Sep 23, 2024
For the diagnostic EDMF case, `ᶜ∇²tke⁰` is only used when `prognostic_tke` is true. This commit ensures that the variable is added to the cache only in that case. Prior to this commit, `ᶜ∇²tke⁰` was added unconditionally and would never be updated, so that it was always full with random numbers (being initialized with similar).
Sbozzolo
force-pushed
the
gb/tke_diag
branch
from
49b8be3 to
1f36cd4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the diagnostic EDMF case,
ᶜ∇²tke⁰is only used whenprognostic_tkeis true. This commit ensures that the variable is added to the cache only in that case. Prior to this commit,ᶜ∇²tke⁰was added unconditionally and would never be updated, so that it was always full with random numbers (being initialized with similar).