add a lower limit for pressure in radiation #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
approved these changes
Oct 1, 2024
szy21
force-pushed
the
zs/limit_pressure
branch
from
b6c1d8b to
19e6c29
Compare
|
I updated the code comment and the PR message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When add_isothermal_boundary_layer is true, we add a layer in rrtmgp and set the pressure to half of the sum of top level pressure and rrtmgp minimum pressure here. This PR limits the pressure to p_min multiplied by a small number to prevent pressure from decreasing or being constant with height at the top level.
This unfortunately not always works (e.g. it seems to be affected by sponge parameters). But I think overall it's still an improvement and we should add it.
To-do
Content