Add check for accumulated diagnostics and restarts #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/diagnostics
branch
4 times, most recently
from
e3f7589 to
ea8042d
Compare
Sbozzolo
force-pushed
the
gb/diagnostics
branch
from
ea8042d to
98c6537
Compare
Sbozzolo
force-pushed
the
gb/diagnostics
branch
2 times, most recently
from
8bb56be to
c47175d
Compare
This commit adds a warning when we can detect checkpointing and diagnostics being out of sync. ClimaAtmos now detects what frequencies are involved and print them out, e.g. ``` [ Info: Saving accumulated diagnostics to disk with frequency: 2 days, 1 day ``` Then, it checks that all these frequencies evenly divide the checkpointing frequency. If this does not happen, a warning is produced.
Sbozzolo
force-pushed
the
gb/diagnostics
branch
from
c47175d to
0b822ef
Compare
szy21
approved these changes
Oct 24, 2024
charleskawczynski
approved these changes
Oct 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a warning when we can detect checkpointing and diagnostics being out of sync. ClimaAtmos now detects what frequencies are involved and print them out, e.g.
Then, it checks that all these frequencies evenly divide the checkpointing frequency. If this does not happen, a warning is produced.
Closes #3309
Closes #2604