Adds Soares test case with smooth detrainment #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julians42
force-pushed
the
j/soares_pr
branch
from
ab211f0 to
dddf648
Compare
szy21
reviewed
Dec 10, 2024
| edmfx_sgs_diffusive_flux: true | ||
| edmfx_nh_pressure: true | ||
| edmfx_filter: true | ||
| prognostic_tke: false # should we set this as true or false? |
There was a problem hiding this comment.
What happens if it is set to true?
.buildkite/pipeline.yml
Outdated
| artifact_paths: "prognostic_edmfx_soares_column/output_active/*" | ||
| agents: | ||
| slurm_mem: 20GB | ||
| soft_fail: true |
There was a problem hiding this comment.
No - I removed this. Was copying what I'd done previously.
reproducibility_tests/ref_counter.jl
Outdated
There was a problem hiding this comment.
You don't need to change the ref counter if you don't add a reproducibility test.
There was a problem hiding this comment.
Yes - Akshay and I were testing because we ran into a ci bug which has since been fixed. I've rebased to main version of ref_counter.jl
Julians42
force-pushed
the
j/soares_pr
branch
from
883d606 to
efa9852
Compare
costachris
approved these changes
Dec 17, 2024
szy21
reviewed
Dec 17, 2024
Update config/model_configs/prognostic_edmfx_soares_column.yml Co-authored-by: Zhaoyi Shen <[email protected]> removes softfail and comment in yml Update config/model_configs/prognostic_edmfx_soares_column.yml Co-authored-by: Zhaoyi Shen <[email protected]>
Julians42
force-pushed
the
j/soares_pr
branch
from
5d01695 to
7fc7299
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds soares test case following Soares 2004 paper that uses smooth area detrainment closure.
To-do
Content