Add distributed_remapping.jl #1475

Sbozzolo · 2023-09-26T23:18:24Z

This pull request introduces a new way to interpolate a field onto a given set of points that works for distributed simulations.

This change introduces a new object, a Remapper. Remappers are process-local and are defined starting from the target points where we want to interpolate and the Space. Remappers contain all the information necessary to perform interpolations of all the fields that are defined on the same Space.

Once a Remapper is defined, it can be used as many times as needed. To use a Remapper, just call the new interpolate function with the field you want to remap:

remapper = Remapper(hcoords, zcoords, space)
interpolate(remapper, field) 
# => Array of values interpolated on hcoords × zcoords

Internally, interpolate computes the process-local points and then calls a MPI.reduce to return the final value in the root process.

Sbozzolo · 2023-09-27T23:04:32Z

bors try

bors · 2023-09-27T23:09:55Z

try

Build failed:

lib-climacore-tempestremap

Sbozzolo · 2023-09-27T23:57:27Z

bors try

bors · 2023-09-28T02:00:37Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sbozzolo · 2023-10-02T21:23:20Z

bors try

bors · 2023-10-02T21:25:53Z

try

Build failed:

format

Sbozzolo · 2023-10-03T17:20:01Z

bors try

bors · 2023-10-03T18:08:20Z

try

Build failed:

format

simonbyrne · 2023-10-03T21:14:32Z

test/Remapping/distributed_remapping.jl

+
+    coords = Fields.coordinate_field(hv_center_space)
+
+    xpts = range(-500.0, 500.0, length = 21)


I think you should be able to just do

Suggested change

xpts = range(-500.0, 500.0, length = 21)

xpts = range(-Geometry.XPoint(500.0), Geometry.XPoint(500.0), length = 21)

I can do this only in the case of a plane.

I need to build hcoords with the correct type, and I cannot easily assemble, e.g., XYPoints from XPoints and YPoints (see #1476).

test/Remapping/distributed_remapping.jl

Sbozzolo · 2023-10-04T15:35:03Z

bors try

bors · 2023-10-04T16:17:38Z

try

Build failed:

buildkite/climacore-ci

Sbozzolo · 2023-10-04T16:58:33Z

bors try

bors · 2023-10-04T19:01:14Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sbozzolo · 2023-10-04T19:22:59Z

@charleskawczynski if you want to have another look, I think that this is ready to be merged

simonbyrne · 2023-10-04T21:40:27Z

bors r+

1464: Check if "ClimaCore version" is already attribute r=simonbyrne a=Sbozzolo HDF5.jl complains if you try writing an attribute that already exists, so that appending to `ClimaCore`-generated files can be a problem 1475: Add distributed_remapping.jl r=simonbyrne a=Sbozzolo This pull request introduces a new way to interpolate a field onto a given set of points that works for distributed simulations. This change introduces a new object, a `Remapper`. `Remapper`s are process-local and are defined starting from the target points where we want to interpolate and the `Space`. `Remapper`s contain all the information necessary to perform interpolations of all the fields that are defined on the same `Space`. Once a `Remapper` is defined, it can be used as many times as needed. To use a `Remapper`, just call the new `interpolate` function with the field you want to remap: ```julia remapper = Remapper(hcoords, zcoords, space) interpolate(remapper, field) # => Array of values interpolated on hcoords × zcoords ``` Internally, `interpolate` computes the process-local points and then calls a `MPI.reduce` to return the final value in the root process. Co-authored-by: Gabriele Bozzola <[email protected]>

bors · 2023-10-05T02:08:48Z

This PR was included in a batch that timed out, it will be automatically retried

charleskawczynski · 2023-10-05T02:21:27Z

src/Remapping/interpolate_array.jl

+end
+
+function interpolation_weights(
+    horz_mesh::Meshes.AbstractMesh1D,


At some point I’d like to rename this variable, maybe just use hmesh?

bors · 2023-10-05T03:23:34Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sbozzolo added Work-in-progress distributed remapping Do-not-merge diagnostic labels Sep 26, 2023

Sbozzolo self-assigned this Sep 26, 2023

Sbozzolo force-pushed the gb/interpolate_mpi branch from 41736a4 to 922ffa1 Compare September 27, 2023 00:23

Sbozzolo mentioned this pull request Sep 27, 2023

OKR O.3.2.2: A flexible diagnostic module for ClimaAtmos CliMA/ClimaAtmos.jl#2043

Closed

Sbozzolo force-pushed the gb/interpolate_mpi branch 4 times, most recently from 806e680 to e6d9b3a Compare September 27, 2023 22:59

Sbozzolo removed Work-in-progress Do-not-merge labels Sep 27, 2023

bors bot added a commit that referenced this pull request Sep 27, 2023

Try #1475:

6998d8e

Sbozzolo force-pushed the gb/interpolate_mpi branch from e6d9b3a to 42b111c Compare September 27, 2023 23:41

bors bot added a commit that referenced this pull request Sep 27, 2023

Try #1475:

77ba2f2

Sbozzolo force-pushed the gb/interpolate_mpi branch 2 times, most recently from 5177405 to 694e3eb Compare September 29, 2023 23:42

Sbozzolo marked this pull request as ready for review October 2, 2023 16:35

Sbozzolo mentioned this pull request Oct 2, 2023

Add support for online remapping CliMA/ClimaAtmos.jl#2179

Merged

Sbozzolo force-pushed the gb/interpolate_mpi branch 2 times, most recently from c464007 to adb5fbb Compare October 2, 2023 21:22

bors bot added a commit that referenced this pull request Oct 2, 2023

Try #1475:

423089d

Sbozzolo force-pushed the gb/interpolate_mpi branch from 796e659 to 089f1e4 Compare October 3, 2023 17:41

bors bot added a commit that referenced this pull request Oct 3, 2023

Try #1475:

88afc3d

Sbozzolo force-pushed the gb/interpolate_mpi branch 2 times, most recently from 3a9d76e to 6b40a07 Compare October 3, 2023 20:19

simonbyrne reviewed Oct 3, 2023

View reviewed changes

test/Remapping/distributed_remapping.jl Outdated Show resolved Hide resolved

Sbozzolo force-pushed the gb/interpolate_mpi branch 2 times, most recently from c329941 to 13ba6be Compare October 3, 2023 23:49

bors bot added a commit that referenced this pull request Oct 4, 2023

Try #1475:

9627dad

simonbyrne approved these changes Oct 4, 2023

View reviewed changes

Sbozzolo added 4 commits October 4, 2023 09:58

Add distributed_remapping.jl

362fc77

Add support for horizontal spaces and planes in distributed_remapping

cef692c

Add interpolation_weights

1457579

Add test with 1 process for distributed_remapping

3904a2a

Sbozzolo force-pushed the gb/interpolate_mpi branch from 13ba6be to 3904a2a Compare October 4, 2023 16:58

bors bot added a commit that referenced this pull request Oct 4, 2023

Try #1475:

d5a81d1

charleskawczynski reviewed Oct 5, 2023

View reviewed changes

bors bot merged commit 6e07029 into main Oct 5, 2023

bors bot deleted the gb/interpolate_mpi branch October 5, 2023 03:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add distributed_remapping.jl #1475

Add distributed_remapping.jl #1475

Sbozzolo commented Sep 26, 2023 •

edited

Loading

Sbozzolo commented Sep 27, 2023

bors bot commented Sep 27, 2023

Sbozzolo commented Sep 27, 2023

bors bot commented Sep 28, 2023

Sbozzolo commented Oct 2, 2023

bors bot commented Oct 2, 2023

Sbozzolo commented Oct 3, 2023

bors bot commented Oct 3, 2023

simonbyrne Oct 3, 2023

Sbozzolo Oct 3, 2023

Sbozzolo commented Oct 4, 2023

bors bot commented Oct 4, 2023

Sbozzolo commented Oct 4, 2023

bors bot commented Oct 4, 2023

Sbozzolo commented Oct 4, 2023

simonbyrne commented Oct 4, 2023

bors bot commented Oct 5, 2023

charleskawczynski Oct 5, 2023

bors bot commented Oct 5, 2023


		coords = Fields.coordinate_field(hv_center_space)

		xpts = range(-500.0, 500.0, length = 21)

	xpts = range(-500.0, 500.0, length = 21)
	xpts = range(-Geometry.XPoint(500.0), Geometry.XPoint(500.0), length = 21)

Add distributed_remapping.jl #1475

Add distributed_remapping.jl #1475

Conversation

Sbozzolo commented Sep 26, 2023 • edited Loading

Sbozzolo commented Sep 27, 2023

bors bot commented Sep 27, 2023

try

Sbozzolo commented Sep 27, 2023

bors bot commented Sep 28, 2023

try

Sbozzolo commented Oct 2, 2023

bors bot commented Oct 2, 2023

try

Sbozzolo commented Oct 3, 2023

bors bot commented Oct 3, 2023

try

simonbyrne Oct 3, 2023

Choose a reason for hiding this comment

Sbozzolo Oct 3, 2023

Choose a reason for hiding this comment

Sbozzolo commented Oct 4, 2023

bors bot commented Oct 4, 2023

try

Sbozzolo commented Oct 4, 2023

bors bot commented Oct 4, 2023

try

Sbozzolo commented Oct 4, 2023

simonbyrne commented Oct 4, 2023

bors bot commented Oct 5, 2023

charleskawczynski Oct 5, 2023

Choose a reason for hiding this comment

bors bot commented Oct 5, 2023

Sbozzolo commented Sep 26, 2023 •

edited

Loading