-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Julia 1.11 #2117
base: main
Are you sure you want to change the base?
Upgrade to Julia 1.11 #2117
Conversation
We were able to sidestep JuliaLang/julia#56295 by dispatching from |
The only remaining issue is that there is still a compile-time regression, but perhaps that's okay with us since we're using the depot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should remove the checks for versions prior to 1.11: we still want to be able to run with 1.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
79cc3c6
to
264eac7
Compare
Ah, this requires changing the github status, that's why the required checks aren't starting. |
264eac7
to
5fa37b2
Compare
I think JET, which is used in the test suite, is not yet compatible with Julia 1.11. So we may need to wait for that afterall. (at least in ClimaCore CI). |
Could you paste a link to the error? I don't see clear signs in the repo for JET saying that it is not compatible with 1.11 (but I can totally believe that it doesn't work) |
https://buildkite.com/clima/climacore-ci/builds/4899#0194487a-5e29-48c7-a04e-524846f2a78f/198-1147 |
Interesting. I can install JET locally in my base env with 1.11.2, but not in the climacore enviornment. It probably conflicts with something else. I can look into this |
I think I found it! SnoopCompile was pinned to 2 (3 is available) |
Yes, it was SnoopCompile, which force JET to use version 0.8 instead of 0.9. I pushed a new commit with the updated Manifest. |
4c7ad61
to
0fea9f8
Compare
4d4afb3
to
82172b3
Compare
This PR upgrades us to Julia 1.11, and lifts some of the conditionals.
Closes #2030