Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Julia 1.11 #2117

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrade to Julia 1.11 #2117

wants to merge 6 commits into from

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jan 6, 2025

This PR upgrades us to Julia 1.11, and lifts some of the conditionals.

Closes #2030

@charleskawczynski
Copy link
Member Author

We were able to sidestep JuliaLang/julia#56295 by dispatching from Base.copyto! directly, so we can still overload getindex on linear indices. The commit where we originally saw this issue, 9795581, had a different dispatch pattern in Base.copyto! for datalayouts. The main branch is dispatching more carefully.

@charleskawczynski
Copy link
Member Author

The only remaining issue is that there is still a compile-time regression, but perhaps that's okay with us since we're using the depot.

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove the checks for versions prior to 1.11: we still want to be able to run with 1.10

.buildkite/scaling/pipeline.yml Show resolved Hide resolved
.github/workflows/ClimaCoreMakie.yml Outdated Show resolved Hide resolved
ext/cuda/data_layouts_copyto.jl Show resolved Hide resolved
ext/cuda/data_layouts_fill.jl Show resolved Hide resolved
ext/cuda/data_layouts_fused_copyto.jl Show resolved Hide resolved
src/DataLayouts/DataLayouts.jl Show resolved Hide resolved
@Sbozzolo Sbozzolo self-requested a review January 7, 2025 15:27
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charleskawczynski charleskawczynski force-pushed the ck/julia111 branch 4 times, most recently from 79cc3c6 to 264eac7 Compare January 8, 2025 20:44
@charleskawczynski
Copy link
Member Author

Ah, this requires changing the github status, that's why the required checks aren't starting.

@charleskawczynski
Copy link
Member Author

I think JET, which is used in the test suite, is not yet compatible with Julia 1.11. So we may need to wait for that afterall. (at least in ClimaCore CI).

cc @Sbozzolo, @sriharshakandala

@Sbozzolo
Copy link
Member

I think JET, which is used in the test suite, is not yet compatible with Julia 1.11. So we may need to wait for that afterall. (at least in ClimaCore CI).

cc @Sbozzolo, @sriharshakandala

Could you paste a link to the error? I don't see clear signs in the repo for JET saying that it is not compatible with 1.11 (but I can totally believe that it doesn't work)

@charleskawczynski
Copy link
Member Author

Could you paste a link to the error? I don't see clear signs in the repo for JET saying that it is not compatible with 1.11 (but I can totally believe that it doesn't work)

https://buildkite.com/clima/climacore-ci/builds/4899#0194487a-5e29-48c7-a04e-524846f2a78f/198-1147

@Sbozzolo
Copy link
Member

Could you paste a link to the error? I don't see clear signs in the repo for JET saying that it is not compatible with 1.11 (but I can totally believe that it doesn't work)

https://buildkite.com/clima/climacore-ci/builds/4899#0194487a-5e29-48c7-a04e-524846f2a78f/198-1147

Interesting. I can install JET locally in my base env with 1.11.2, but not in the climacore enviornment. It probably conflicts with something else. I can look into this

@Sbozzolo
Copy link
Member

I think I found it! SnoopCompile was pinned to 2 (3 is available)

@Sbozzolo
Copy link
Member

Yes, it was SnoopCompile, which force JET to use version 0.8 instead of 0.9. I pushed a new commit with the updated Manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants