Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In Holloway and Manabe 1971 it says
The current code sets the tendency to zero if it results in T above freezing, which differs from the paper. I change it to clip the tendency to (T_freeze - T) / dt, which should match the paper more closely. I also remove a comment about sublimation which doesn't seem to be true in the code.
Edit: One out of four simulations break with dt 240 in the latest nightly build: https://buildkite.com/clima/climacoupler-coarse-nightly-amip/builds/73. So I change dt back to 180 in this PR, and change t_end to one and a half years.
To-do
I will revert the change in nightly pipeline before merging.
Content