Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipping sea ice tendencies #1010

Merged
merged 2 commits into from
Oct 11, 2024
Merged

clipping sea ice tendencies #1010

merged 2 commits into from
Oct 11, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Oct 10, 2024

Purpose

In Holloway and Manabe 1971 it says

If the solution to this heat balance equation results in a value of T* above freezing, this value is set back to freezing with the implicit assumption that the excess heat is used for melting pack ice.

The current code sets the tendency to zero if it results in T above freezing, which differs from the paper. I change it to clip the tendency to (T_freeze - T) / dt, which should match the paper more closely. I also remove a comment about sublimation which doesn't seem to be true in the code.

Edit: One out of four simulations break with dt 240 in the latest nightly build: https://buildkite.com/clima/climacoupler-coarse-nightly-amip/builds/73. So I change dt back to 180 in this PR, and change t_end to one and a half years.

To-do

I will revert the change in nightly pipeline before merging.

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/sea_ice branch 6 times, most recently from 763452c to f6912d5 Compare October 10, 2024 22:56
@szy21 szy21 requested a review from juliasloan25 October 10, 2024 22:59
@szy21 szy21 marked this pull request as ready for review October 10, 2024 22:59
@szy21 szy21 requested a review from Sbozzolo October 10, 2024 23:01
@szy21 szy21 force-pushed the zs/sea_ice branch 2 times, most recently from 9da6d5f to 187650c Compare October 11, 2024 03:58
@szy21
Copy link
Member Author

szy21 commented Oct 11, 2024

Update: One out of four simulations break with dt 240 in the latest nightly build: https://buildkite.com/clima/climacoupler-coarse-nightly-amip/builds/73. So I change dt back to 180 in this PR, and change t_end to one and a half years.

@szy21 szy21 force-pushed the zs/sea_ice branch 3 times, most recently from 73e2b67 to 3b5e7bc Compare October 11, 2024 17:07
@szy21 szy21 merged commit 82ac791 into main Oct 11, 2024
8 checks passed
@szy21 szy21 deleted the zs/sea_ice branch October 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants